RFR: 8354702: [TestBug] LocalDateTimeStringConverterTest Workaround can be removed
Andy Goryachev
angorya at openjdk.org
Tue Apr 15 20:38:55 UTC 2025
On Tue, 15 Apr 2025 20:16:04 GMT, Marius Hanl <mhanl at openjdk.org> wrote:
> [JDK-8297316](https://bugs.openjdk.org/browse/JDK-8297316) added a Workaround for the Japanese Date Converter, which is different on JDK20 and newer. Since our Boot JDK is Java 22 as of April 2025, we can remove the workaround.
>
> We should also consider testing and closing: [JDK-8265727](https://bugs.openjdk.org/browse/JDK-8265727) and [JDK-8141350](https://bugs.openjdk.org/browse/JDK-8141350), which seems to work fine for me (German Locale, Test correctly changes that).
Looks good.
Unrelated note: the last three tests should not be parameterized since they seem to be testing specific conditions (we missed this during the review).
Since this is a test, we could fix it as a part of this PR, though I am sure @kevinrushforth would want a new JBS ticket.
-------------
Marked as reviewed by angorya (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/1778#pullrequestreview-2769744814
More information about the openjfx-dev
mailing list