RFR: 8354455: [TestBug] Remove JUnit Vintage Engine with JUnit 4 [v2]

[Kevin Rushforth]

On Sat, 12 Apr 2025 00:23:07 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> These are the remaining bits and pieces in order to completely remove the JUnit Vintage Engine, and therefore JUnit 4 from JavaFX.
>> After that, we should either document, that JUnit5 is used (just as information) or close [JDK-8296284](https://bugs.openjdk.org/browse/JDK-8296284) (Since you can not use JUnit4 anymore).
>> 
>> This also removes the `org.hamcrest` dependency, which is actually only used in one test where it can easily be replaced by a `Predicate` (instead of `Matcher`). I'm not convinced that we should keep that dependency for just one test.
>> 
>> ~Note: I could not get the `:swt` tests to compile/test, in order to run the tests. 
>> I need some guidance here how to instruct `Gradle` to compile this module (and if I need anything else? like swt?).~
>> 
>> ~Also, this probably needs an extra ticket in the JBS?~
>
> Marius Hanl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix SWT Tests

The changes look good. I note that there is a missing comma in the copyright line of the newly added file. I'll reapprove once you correct this.

All my testing is green, including closed tests.

modules/javafx.swt/src/test/java/test/javafx/embed/swt/SWTTest.java line 2:

> 1: /*
> 2:  * Copyright (c) 2025 Oracle and/or its affiliates. All rights reserved.

You need a comma after `2025`

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1774#pullrequestreview-2770034776
PR Review Comment: https://git.openjdk.org/jfx/pull/1774#discussion_r2045619487