RFR: 8354795: DialogPane show details button wipes out base style class "hyperlink"

John Hendrikx jhendrikx at openjdk.org
Wed Apr 16 08:55:55 UTC 2025


The "show details" hyperlink button in an alert dialog that has an expandable detail area wipes out its base style class by overwriting all styles. This means styling in modena.css that targets `.hyperlink` is no longer applied, like the default text fill colors.

The culprit is this code in DialogPane:

        InvalidationListener expandedListener = o -> {
            final boolean isExpanded = isExpanded();
            detailsButton.setText(isExpanded ? lessText : moreText);
            detailsButton.getStyleClass().setAll("details-button", (isExpanded ? "less" : "more")); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
        };

Here it uses `setAll` to set styles, wiping out the default `.hyperlink` style from "Hyperlink detailsButton = new HyperLink()"

-------------

Commit messages:
 - Fix style classes

Changes: https://git.openjdk.org/jfx/pull/1779/files
  Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1779&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8354795
  Stats: 13 lines in 1 file changed: 3 ins; 5 del; 5 mod
  Patch: https://git.openjdk.org/jfx/pull/1779.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1779/head:pull/1779

PR: https://git.openjdk.org/jfx/pull/1779


More information about the openjfx-dev mailing list