RFR: 8354797: Parent.needsLayoutProperty() should return read-only getter

Marius Hanl mhanl at openjdk.org
Wed Apr 16 18:42:45 UTC 2025


On Wed, 16 Apr 2025 16:45:32 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> `Parent.needsLayout` is implemented with a `ReadOnlyBooleanWrapper`. The property getter returns the wrapper itself, but what it should be doing is return the read-only getter instead.
>> 
>> A single reviewer should be sufficient.
>
> Looks good.
> 
> Do you know if there is an easy way to find similar issues elsewhere?

@andy-goryachev-oracle I think one way to actually test something like this could be to use `Archunit`. 
The usecase of it is to actually test the architecture of your code (e.g. a pattern, imports, annotations, ...).

But we need a new dependency, and to write such somewhat complex rules is also not that easy. I used it in the past and I really liked it. So, just FYI.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1780#issuecomment-2810414429


More information about the openjfx-dev mailing list