RFR: 8354813: Parent.isNeedsLayout() may return wrong value in property listener [v2]
Andy Goryachev
angorya at openjdk.org
Wed Apr 16 19:40:49 UTC 2025
On Wed, 16 Apr 2025 18:43:01 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:
>> A listener that is added to `Parent.needsLayoutProperty()` may see a wrong value when calling `Parent.isNeedsLayout()` from the callback. The fix is to apply the value before notifying the listeners.
>
> Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>
> - Merge branch 'master' into fixes/needslayout-wrong-value
>
> # Conflicts:
> # modules/javafx.graphics/src/test/java/test/javafx/scene/ParentTest.java
> - fix
> - failing test
I see no ill effects in the TableView.
Just to be on the safe side, I tried to re-create the scenario with the canvas-based cell and row factories in the monkey tester, and I did not see any issues.
-------------
Marked as reviewed by angorya (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/1781#pullrequestreview-2773650906
More information about the openjfx-dev
mailing list