RFR: 8088343: Intermittent unit test failure in javafx.concurrent.ServiceLifecycleTest [v3]
Andy Goryachev
angorya at openjdk.org
Wed Apr 16 20:28:14 UTC 2025
> The code should not set the `Task.state` value to `CANCELLED` if the said task is already `SUCCEEDED` or `FAILED`.
>
> This is a product bug.
>
> Added `@RepeatedTest(50)` to the tests that used to fail intermittently - this made the test failed more reliably without the fix.
Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
- cleanup
- review comments
- Merge remote-tracking branch 'origin/master' into 8088343.lifecycle
- Merge remote-tracking branch 'origin/master' into 8088343.lifecycle
- 8088343
-------------
Changes:
- all: https://git.openjdk.org/jfx/pull/1769/files
- new: https://git.openjdk.org/jfx/pull/1769/files/d605fb92..66d2edb9
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jfx&pr=1769&range=02
- incr: https://webrevs.openjdk.org/?repo=jfx&pr=1769&range=01-02
Stats: 574 lines in 20 files changed: 204 ins; 200 del; 170 mod
Patch: https://git.openjdk.org/jfx/pull/1769.diff
Fetch: git fetch https://git.openjdk.org/jfx.git pull/1769/head:pull/1769
PR: https://git.openjdk.org/jfx/pull/1769
More information about the openjfx-dev
mailing list