RFR: 8169285: Re-enable javafx.swt tests [v2]

Kevin Rushforth kcr at openjdk.org
Wed Apr 16 22:02:43 UTC 2025


On Wed, 16 Apr 2025 21:51:42 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> > yes, we still need `SWT_TEST` so we can disable it on mac.
> 
> If that flag is the mechanism we need to use to disable it on macOS, then we will need the following additional change:
> 
> ```
>  // Specifies whether to run system tests that depend on SWT (only used when FULL_TEST is also enabled)
> -defineProperty("SWT_TEST", "true")
> +defineProperty("SWT_TEST", IS_MAC ? "false" ? "true")
>  ext.IS_SWT_TEST = Boolean.parseBoolean(SWT_TEST);
> ```

Never mind. There is already this:


        if (IS_MAC) {
            enabled = false
            logger.info("SWT tests are disabled on MAC, because Gradle test runner does not handle -XstartOnFirstThread properly (https://issues.gradle.org/browse/GRADLE-3290).")
        }

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1783#issuecomment-2810909886


More information about the openjfx-dev mailing list