RFR: 8354795: DialogPane show details button wipes out base style class "hyperlink"

[John Hendrikx]

On Wed, 16 Apr 2025 20:59:28 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> An SCCE would have been nice, to help with the review/testing.
> 
> edit: alternatively, I'll add the (missing) Dialog/DialogPane page to the monkey tester. 🐒🔬

If you still need one, I can provide a bit of code.  It basically is just changing the hyperlink style, and then seeing it doesn't affect the Alert dialog when it has an extended area.  After the change, it should affect it.  I did include a screenshot -- I may find more of these bugs as I continue developing with modena.css with dark theme colors :)

> modules/javafx.controls/src/main/java/javafx/scene/control/DialogPane.java line 822:
> 
>> 820:         final ObservableList<String> styleClasses = detailsButton.getStyleClass();
>> 821: 
>> 822:         styleClasses.add("details-button");  //$NON-NLS-1$
> 
> do we use these `//$NON-NLS-1$` in jfx?

I do not know if we do, as there is also non-public code that I don't have access to.  I've kept them as-is to make sure the change is focused and doesn't break anything else.

If I had to guess then probably not, if you can ask around and find out I'll be happy to remove them.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1779#issuecomment-2811089058
PR Review Comment: https://git.openjdk.org/jfx/pull/1779#discussion_r2047923713