RFR: 8329227: Seek might hang with fMP4 H.265/HEVC or H.265/HEVC over HTTP/FILE

[Ambarish Rapte]

On Sat, 12 Apr 2025 01:43:29 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

> - Fixed by reloading decoder for each seek.
> - Tested with all H.265 files for HLS/HTTP/FILE, no issues found.
> - Seek performance is not affected or at least I did not notice any performance issues when doing reload for each seek.
> 
> This is workaround and no other reasonable solutions were found.

Change looks good, I could verify that the issue reproduces without this change and gets fixed with this change.
Sanity testing looks good.
Providing couple minor renaming suggestions.

modules/javafx.media/src/main/native/gstreamer/plugins/mfwrapper/mfwrapper.h line 97:

> 95:     BYTE *header;
> 96:     gsize header_size;
> 97:     gboolean send_header;

may be rename as `is_send_header` similar to the other boolean variables of the class.

modules/javafx.media/src/main/native/gstreamer/plugins/mfwrapper/mfwrapper.h line 108:

> 106:     guint pixel_den;
> 107: 
> 108:     gboolean set_caps;

may be rename as `is_set_caps` similar to the other boolean variables of the class.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1775#pullrequestreview-2775016635
PR Review Comment: https://git.openjdk.org/jfx/pull/1775#discussion_r2048505039
PR Review Comment: https://git.openjdk.org/jfx/pull/1775#discussion_r2048505649