RFR: 8352162: Update libxml2 to 2.13.8 [v6]

[Kevin Rushforth]

On Mon, 21 Apr 2025 17:28:12 GMT, Jay Bhaskar <jbhaskar at openjdk.org> wrote:

>> The upgrade is required to address several known issues from the previous version to improve stability and performance.
>
> Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove unused files

I reviewed the `libxslt` update. There are only three issues I saw:

1. The addition of the `libexslt` dir should be reverted
2. The `src/CMakeLists.txt` is likely unneeded and should be removed
4. There is an unexpected diff in one file: `congure.ac`

modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/CMakeLists.txt line 1:

> 1: cmake_minimum_required(VERSION 3.18)

I don't think we use this file in our build. We should remove it if not.

modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/configure.ac line 6:

> 4: m4_define([MAJOR_VERSION], [1])
> 5: m4_define([MINOR_VERSION], [1])
> 6: m4_define([MICRO_VERSION], [44])

This should be `43` not `44`.

modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/configure.ac line 24:

> 22: LIBEXSLT_MAJOR_VERSION=0
> 23: LIBEXSLT_MINOR_VERSION=8
> 24: LIBEXSLT_MICRO_VERSION=25

This should be `24` (not `25`).

modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/libexslt/common.c line 1:

> 1: #define IN_LIBEXSLT

We don't include `libexslt` with jfxwebkit nor do we want to. Please revert the addition of the `libexslt/` directory tree.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1785#pullrequestreview-2782277174
PR Review Comment: https://git.openjdk.org/jfx/pull/1785#discussion_r2053015887
PR Review Comment: https://git.openjdk.org/jfx/pull/1785#discussion_r2053016916
PR Review Comment: https://git.openjdk.org/jfx/pull/1785#discussion_r2053017222
PR Review Comment: https://git.openjdk.org/jfx/pull/1785#discussion_r2053020232