RFR: 8352162: Update libxml2 to 2.13.8 [v6]
Jay Bhaskar
jbhaskar at openjdk.org
Tue Apr 22 10:37:53 UTC 2025
On Mon, 21 Apr 2025 19:10:02 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:
>>
>> remove unused files
>
> modules/javafx.web/src/main/native/Source/ThirdParty/libxml/mac/include/xmlversion.h line 1:
>
>> 1: /*
>
> This file is not used and should be deleted. It looks like a spurious copy of `mac/include/libxml/xmlversion.h`.
we need to keep [xmlversion.h], when we update we usually compare the macro
> modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/configure.ac line 6:
>
>> 4: m4_define([MAJOR_VERSION], [1])
>> 5: m4_define([MINOR_VERSION], [1])
>> 6: m4_define([MICRO_VERSION], [44])
>
> This should be `43` not `44`.
[onfigure.ac] removed now not needed
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1785#discussion_r2053836403
PR Review Comment: https://git.openjdk.org/jfx/pull/1785#discussion_r2053839747
More information about the openjfx-dev
mailing list