RFR: 8347359: RichTextArea API Tests [v8]
Andy Goryachev
angorya at openjdk.org
Tue Apr 22 22:39:50 UTC 2025
On Tue, 22 Apr 2025 20:36:55 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 27 commits:
>>
>> - rm junit4
>> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests
>> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests
>> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests
>> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests
>> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests
>> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests
>> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests
>> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests
>> - Merge remote-tracking branch 'origin/8348736.rta.followup.2' into 8347359.rta.api.tests
>> - ... and 17 more: https://git.openjdk.org/jfx/compare/703a9a90...0fb16fdc
>
> modules/jfx.incubator.richtext/src/test/java/test/jfx/incubator/scene/util/TUtil.java line 49:
>
>> 47: Thread.currentThread().setUncaughtExceptionHandler((thread, throwable) -> {
>> 48: if (throwable instanceof RuntimeException) {
>> 49: throw (RuntimeException)throwable;
>
> Why is RuntimeException treated differently than checked Exception and Error?
hmmm... This pattern was copied from some other test. We have 32 more instances of this pattern elsewhere.
I suspect it is not avoid declaring a checked exception.
What would you suggest? Forward the `throwable` to `Thread.currentThread().getThreadGroup().uncaughtException(thread, throwable);` unconditionally?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1677#discussion_r2054983255
More information about the openjfx-dev
mailing list