RFR: 8347359: RichTextArea API Tests [v8]

Andy Goryachev angorya at openjdk.org
Wed Apr 23 18:41:02 UTC 2025


On Tue, 22 Apr 2025 23:12:37 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> modules/jfx.incubator.richtext/src/test/java/test/jfx/incubator/scene/control/richtext/RichTextAreaTest.java line 466:
>> 
>>> 464: 
>>> 465:     @Test
>>> 466:     public void modelChangeClearsSelection() {
>> 
>> Since the actual data is sorted in the model, it might also be good to test that a model change clears all of the text that you have previously appended (in another test method).
>
>> Since the actual data is sorted
> 
> Typo, I meant "stored"

each test starts with a freshly created model, but it's a good idea to add a check for the content.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1677#discussion_r2056682427


More information about the openjfx-dev mailing list