Integrated: 8318985: [macos] Incorrect 3D lighting on macOS 14 and later
Jayathirth D V
jdv at openjdk.org
Thu Apr 24 11:42:52 UTC 2025
On Wed, 23 Apr 2025 12:13:52 GMT, Jayathirth D V <jdv at openjdk.org> wrote:
> When no specular color is set while rendering 3D primitives, 0.0 specular power value is used by default in our shaders.
> When same specular power value is used in pow() function in shader it results in undefined behaviour as mentioned at : https://registry.khronos.org/OpenGL-Refpages/es3.0/html/pow.xhtml
>
> By default specular power value should be 32, so now the specular_none.frag file is updated to use this default value to make sure we don't see 3D lighting issues on some platforms. This change is tested with Ensemble8 and fx83dfeatures and i don't see any regressions.
>
> Also one of our system test _PointLightIlluminationTest_ used to fail because of this issue. It passes now with this update and it is re-enabled.
This pull request has now been integrated.
Changeset: 2617ff5c
Author: Jayathirth D V <jdv at openjdk.org>
URL: https://git.openjdk.org/jfx/commit/2617ff5c891ba182581d323d8b424e4b8a6a6b63
Stats: 35 lines in 2 files changed: 2 ins; 32 del; 1 mod
8318985: [macos] Incorrect 3D lighting on macOS 14 and later
Reviewed-by: kcr, arapte
-------------
PR: https://git.openjdk.org/jfx/pull/1791
More information about the openjfx-dev
mailing list