RFR: 8088343: Race condition in javafx.concurrent.Task::cancel [v3]
Andy Goryachev
angorya at openjdk.org
Thu Apr 24 14:42:03 UTC 2025
On Wed, 16 Apr 2025 20:28:14 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> The code should not set the `Task.state` value to `CANCELLED` if the said task is already `SUCCEEDED` or `FAILED`.
>>
>> This is a product bug.
>>
>> Added `@RepeatedTest(50)` to the tests that used to fail intermittently - this made the test failed more reliably without the fix.
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>
> - cleanup
> - review comments
> - Merge remote-tracking branch 'origin/master' into 8088343.lifecycle
> - Merge remote-tracking branch 'origin/master' into 8088343.lifecycle
> - 8088343
Thank you Kevin and Ambarish!
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1769#issuecomment-2827885167
More information about the openjfx-dev
mailing list