RFR: 8354336: gstclock.c: compilation error: 'incompatible pointer type' with gcc 14

[Kevin Rushforth]

On Thu, 24 Apr 2025 20:56:52 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

>> modules/javafx.media/src/main/native/gstreamer/gstreamer-lite/gstreamer/gst/gst_private.h line 535:
>> 
>>> 533: {
>>> 534:   GstClockEntry entry;
>>> 535: #if defined (GSTREAMER_LITE) && defined(LINUX)
>> 
>> Why is this qualified with `defined(LINUX)`? Unless the usage of this variable is different based on the platform, I would expect that the type is wrong on all platforms. Am I missing something?
>
> This is old code which was restored from GStreamer 1.20.1 and only needed on Linux to support older GLib.
> See https://github.com/openjdk/jfx/pull/1290.

Thanks for the explanation.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1794#discussion_r2059298064