RFR: 8354943: [Linux] Simplify and update glass gtk backend: window sizing, positioning, and state management issues [v5]

Thiago Milczarek Sayao tsayao at openjdk.org
Thu Apr 24 22:39:50 UTC 2025


On Thu, 24 Apr 2025 13:58:05 GMT, Martin Fox <mfox at openjdk.org> wrote:

>> Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Reenable RestoreSceneSizeTest (JDK-8353556)
>
> tests/system/src/test/java/test/javafx/stage/SizingTest.java line 164:
> 
>> 162:             mode = EnumSource.Mode.INCLUDE,
>> 163:             names = {"DECORATED", "UNDECORATED", "TRANSPARENT"})
>> 164:     void testFullScreenMaxSize(StageStyle stageStyle) {
> 
> You're assuming that fullscreen mode should ignore the max size properties. That's not how Windows 11 and macOS work. On macOS the window expands to the max size and is then centered on a black screen. On Windows 11 it ends up in the upper left corner with the desktop showing beneath it. It looks weird but I don't think there's much point to changing the implementation on these two platforms.

I’m going to remove this test and undo the workaround I added to support it. I initially thought this behavior was consistent with how it works on Windows, but I think I got confused — Windows does allow a fullscreen, unresizable Stage.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1789#discussion_r2059337917


More information about the openjfx-dev mailing list