RFR: 8350316: Create implementation of NSAccessibilityProgressIndicator protocol

Ambarish Rapte arapte at openjdk.org
Mon Apr 28 10:32:51 UTC 2025


On Mon, 28 Apr 2025 04:37:59 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Initial implementation. In order to implement progress indicator the group accessibility protocol has to be implemented too so this is also a fix for 8351773. There are commented out sections that can be used to verify the functionality of the code since it has to behave exactly in the same way as the code without the fix. After review is done i will remove the debug output.

A minor comment that the 4 new files require an empty line at the end. and I added another inline query.
I shall test the change and update.

modules/javafx.graphics/src/main/native-glass/mac/a11y/JFXProgressIndicatorAccessibility.h line 30:

> 28: #import <AppKit/NSAccessibility.h>
> 29: 
> 30: @interface JFXProgressIndicatorAccessibility :

Will we use the same interface of ProgressBar? If yes, a comment here mentioning the same would be helpful.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1796#pullrequestreview-2798834168
PR Review Comment: https://git.openjdk.org/jfx/pull/1796#discussion_r2063377739


More information about the openjfx-dev mailing list