RFR: 8271024: Implement macOS Metal Rendering Pipeline [v8]
Andy Goryachev
angorya at openjdk.org
Fri Aug 1 15:55:09 UTC 2025
On Fri, 1 Aug 2025 15:19:59 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Yes, Changed the order. Any resources being used by MTLCommandQueue are made resident, so the resources would stay alive even if MTLResourceFactory is disposed. but the earlier order was incorrect.
>
> Normally, this would be the right thing to do. However, it looks like switching the order has introduced several crashes. I discovered this today while testing the latest version of this PR. I bisected it and found out that this was the culprit.
>
> It would be helpful to know why the order matters. If there is a good reason, then a comment would be helpful.
This is alarming - perhaps something in `super.dispose()` calls overriden methods?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1824#discussion_r2248317623
More information about the openjfx-dev
mailing list