RFR: 8271024: Implement macOS Metal Rendering Pipeline [v11]

[Nir Lisker]

On Tue, 29 Jul 2025 16:34:16 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/com/sun/prism/mtl/MTLMeshView.java line 40:
>> 
>>> 38:     private final long nativeHandle;
>>> 39: 
>>> 40:     final private MTLMesh mesh;
>> 
>> `mesh` is unused. Is it awaiting a dereference in `dispose()`?
>
> Yes, MTLMesh can be shared by multiple MTLMeshView.

I'm not sure I understand where is it used? I see that the same `MTLMesh` can be passed to multiple `MTLMeshView`s, but what do they do with it?

>> modules/javafx.graphics/src/main/java/com/sun/prism/mtl/MTLRTTexture.java line 39:
>> 
>>> 37: import com.sun.prism.mtl.MTLTexture;
>>> 38: import com.sun.prism.mtl.MTLTextureData;
>>> 39: import com.sun.prism.mtl.MTLTextureResource;
>> 
>> Unused
>
> MTLTextureResource is used in this class

import com.sun.prism.mtl.MTLContext;
import com.sun.prism.mtl.MTLTexture;
import com.sun.prism.mtl.MTLTextureData;
import com.sun.prism.mtl.MTLTextureResource;

Since they are from the same package, the FQN of these types is known, hence these imports are unused (even if the types are). If you remove these you shouldn't get any compilation error,

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1824#discussion_r2252706415
PR Review Comment: https://git.openjdk.org/jfx/pull/1824#discussion_r2252723807