RFR: 8364825: Skip failing MenuDoubleShortcutTest [v2]
Kevin Rushforth
kcr at openjdk.org
Thu Aug 7 17:57:20 UTC 2025
On Thu, 7 Aug 2025 17:36:49 GMT, Ziad El Midaoui <zelmidaoui at openjdk.org> wrote:
>> Also, this will skip the test on all platforms. That might be a reasonable thing to do, but if that's what you propose, then please change the title (in JBS and the PR) to drop the "on Linux" part.
>
> The test is skipped on Mac by default with `Assumptions.assumeFalse(PlatformUtil.isMac());` , and now it will be also on Linux so skipping it on all platforms won't have critical impact I suppose
It means that this test also won't run on Windows platforms, but that seems OK. When the underlying bug, JDK-8364405, is fixed this test can be reenabled for both Linux and Windows by removing the `@Disabled` annotation.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1867#discussion_r2261055089
More information about the openjfx-dev
mailing list