RFR: 8356982: Update WebKit to 622.1 [v2]

Kevin Rushforth kcr at openjdk.org
Mon Aug 11 21:45:18 UTC 2025


On Mon, 11 Aug 2025 15:25:28 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   additional fixes for webkit
>
> modules/javafx.web/src/main/native/Source/WebCore/Modules/compression/CompressionStreamEncoder.cpp line 91:
> 
>> 89:     return result != Z_OK && result != Z_STREAM_END && result != Z_BUF_ERROR;
>> 90: #endif
>> 91:     return true;
> 
> How did this even compile previously? Is this file actually included in our build?

Independent of how the code compiled before, it was clearly wrong.

So the more interesting question is: Is `true` the right return value for our port of WebKit? That appears to be an error return for this method.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1865#discussion_r2268084256


More information about the openjfx-dev mailing list