RFR: 8354943: [Linux] Simplify and update glass gtk backend: window sizing, positioning, and state management issues [v50]

[Martin Fox]

On Sat, 9 Aug 2025 18:30:10 GMT, Thiago Milczarek Sayao <tsayao at openjdk.org> wrote:

>> tests/system/src/test/java/test/javafx/stage/SizingTest.java line 155:
>> 
>>> 153:     @ParameterizedTest(name = PARAMETERIZED_TEST_DISPLAY)
>>> 154:     @EnumSource(names = {"DECORATED", "UNDECORATED", "EXTENDED", "TRANSPARENT", "UTILITY"})
>>> 155:     void minSize(StageStyle stageStyle) {
>> 
>> The minSize test is failing on Windows for all stage styles. This is a legitimate bug; the platform is not correctly reporting back to the system that the size change failed. I will enter a bug and you can disable this test until the bug is fixed. (macOS is also failing the minSize and maxSize tests).
>
> I've put an `assumeTrue(PlatformUtil.isWindows());` referencing JDK-8364547. Is it the correct bug?

Just remove the assumeTrue call here. I'll submit the fix for JDK-8364547 in the next day or so and then these system tests will just work.

>> tests/system/src/test/java/test/robot/javafx/stage/StageOwnershipTest.java line 267:
>> 
>>> 265:     @ParameterizedTest(name = PARAMETERIZED_TEST_DISPLAY)
>>> 266:     @EnumSource(names = {"DECORATED", "UNDECORATED", "EXTENDED"})
>>> 267:     void iconifyParentShouldHideChildren(StageStyle style) {
>> 
>> These tests are failing on Windows for DECORATED and EXTENDED stages. You've got two levels of owned windows and the second level windows aren't getting minimized. This is due to an OS bug, it doesn't recurse through multiple ownership levels.
>> 
>> I suppose we could enter a bug on this but I doubt it would ever get fixed. It might make more sense to reduce the test to a single level of ownership.
>
> Did an `assumeTrue(PlatformUtil.isWindows());` if style is `EXTENDED` or `UNDECORATED`

I think you use assumeTrue to check whether the test should proceed. So you want `assumeTrue(!PlatformUtil.isWindows())` or `assumeFalse(PlatformUtil.isWindows())`.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1789#discussion_r2276964751
PR Review Comment: https://git.openjdk.org/jfx/pull/1789#discussion_r2276965466