RFR: 8350479: SW pipeline should use default pipeline in Glass [v5]

Ambarish Rapte arapte at openjdk.org
Mon Aug 18 11:14:20 UTC 2025


On Mon, 18 Aug 2025 09:51:31 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

>> We have Metal pipeline also now in macOS apart from OpenGL pipeline for accelerated hardware pipelines.
>> 
>> Currently when Software pipeline is used we continue to use OpenGL(ES2) pipeline on glass side, which is the default hardware pipeline in macOS. If we want to switch to Metal pipeline as default hardware pipeline in prism, we should be able to use Metal pipeline in glass also when software pipeline is used. For this to happen we need to set some information when SWPipeline is getting initialized and pass that information to glass.
>> 
>> This PR adds new flag `useMTLInGlass` in device details when SWPipeline is getting initialized and then passes it to glass code. When SWPipeline is used, based on this flag we will use appropriate hardware pipeline in glass.
>> 
>> Patch is tested when useMTLInGlass is set to true/false and then using -Dprism.order=es2/mtl/sw and it picks proper GlassView/Layer.
>
> Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update

LGTM, Tested with mtl and es2 as default pipeline. Observed no issue in rendering.
suggested a minor change, shall re-approve once changed.

-------------

Marked as reviewed by arapte (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1868#pullrequestreview-3127938722


More information about the openjfx-dev mailing list