RFR: 8361286: Allow enabling of background loading for images loaded from an InputStream [v2]

John Hendrikx jhendrikx at openjdk.org
Wed Aug 20 13:42:51 UTC 2025


On Tue, 19 Aug 2025 21:24:53 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add since tags
>
> modules/javafx.graphics/src/test/java/test/javafx/scene/image/ImageTest.java line 158:
> 
>> 156:     }
>> 157: 
>> 158:     @Test
> 
> Do you think it would make sense to add a test that actually loads a valid image?

I don't think that can be done with the stub toolkit  This test is specifically stubbing/mocking everything out to verify that  `Image` works correctly.  However, there are many areas where (real) images are loaded already, and all the code involved (excluding the new parts in `Image`) was already there in one way or another as the URL variants that allowed background loading is also just an `InputStream` with some extra steps to determine their size (for progress).

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1875#discussion_r2288210520


More information about the openjfx-dev mailing list