RFR: 8354943: [Linux] Simplify and update glass gtk backend: window sizing, positioning, and state management issues [v50]
Thiago Milczarek Sayao
tsayao at openjdk.org
Fri Aug 22 21:08:07 UTC 2025
On Thu, 14 Aug 2025 15:27:14 GMT, Martin Fox <mfox at openjdk.org> wrote:
>> Did an `assumeTrue(PlatformUtil.isWindows());` if style is `EXTENDED` or `UNDECORATED`
>
> I think you use assumeTrue to check whether the test should proceed. So you want `assumeTrue(!PlatformUtil.isWindows())` or `assumeFalse(PlatformUtil.isWindows())`.
I always get confused by this. Will fix it.
>> I fixed the method name, but I think the test is correct - it does get a random color, but it tests for no match.
>
> Since it picks up a random color it could get a match by accident. Highly unlikely but possible. Though I see what you're saying, any time we use a robot to sample a pixel we could get the expected color by chance because it just happens to be in the desktop image.
Good point, I'll fix it.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1789#discussion_r2294744955
PR Review Comment: https://git.openjdk.org/jfx/pull/1789#discussion_r2294743355
More information about the openjfx-dev
mailing list