RFR: 8330559: Trailing space not rendering correctly in TextFlow in RTL mode [v2]

[Andy Goryachev]

On Mon, 15 Dec 2025 11:53:22 GMT, Ziad El Midaoui <zelmidaoui at openjdk.org> wrote:

>> Fix trailing space present for complex text ( LTR text with RTL text ) Example: "Arabic: العربية"
>> Added case to handle complex text in `getPosX` of `TextRun`
>> Tested the changes with the code present in the bug.
>
> Ziad El Midaoui has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into 8319050.TextFlowRTL
>  - Merge branch 'openjdk:master' into 8319050.TextFlowRTL
>  - minor changes
>  - Fix Trailing space in TextFlow in RTL

The fix looks good.

Regarding the unit test(s): we can't really create one using stub text layout, it must be using the real one (in a headful environment).

The problem there is that we'd rely on LayoutInfo which is currently broken (see https://bugs.openjdk.org/browse/JDK-8319050 ).  I suggest we develop a set of tests as a part of or as a follow-up to that ticket.

The manual tests using the reproducer and the monkey tester are ok.

-------------

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1988#pullrequestreview-3579343881