RFR: 8373232: Set default filters and addressing modes for 3D metal textures [v2]
Lukasz Kostyra
lkostyra at openjdk.org
Tue Dec 16 16:10:33 UTC 2025
On Tue, 16 Dec 2025 11:49:31 GMT, Jayathirth D V <jdv at openjdk.org> wrote:
>> Currently we don't set any texture filtering & addressing modes for 3D textures in Metal pipeline.
>> Default 3D texture filtering is "nearest" for Metal textures, but we use "linear" filtering by default for 3D textures in case of OpenGL.
>> Default addressing mode is "clamp_to_edge" in Metal textures, but we use "repeat" addressing mode for 3D textures in OpenGL.
>>
>> Metal should use same default filtering & addressing modes for 3D textures as in OpenGL pipeline.
>> Under this issue we are trying only to match defaults of Metal to OpenGL pipeline.
>>
>> We don't update the filters/addressing modes for 3D textures once created.
>> We have open enhancements like https://bugs.openjdk.org/browse/JDK-8324594 where we might provide API's to set sampler states for 3D textures in future.
>>
>> Functional and performance testing is green with this update.
>
> Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision:
>
> create sampler states only once
LGTM
-------------
Marked as reviewed by lkostyra (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/2005#pullrequestreview-3583876203
More information about the openjfx-dev
mailing list