RFR: 8358450: Viewport characteristics media features [v16]
Michael Strauß
mstrauss at openjdk.org
Tue Dec 16 21:30:22 UTC 2025
On Tue, 16 Dec 2025 21:13:37 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>>
>> documentation
>
> modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html line 971:
>
>> 969: <td class="value">fullscreen | standalone</td>
>> 970: <td>discrete</td>
>> 971: <td><code>fullscreen</code> if <code>Stage.isFullScreen()</code>, <code>standalone</code> otherwise</code></td>
>
> This description is perfectly clear now, thanks!
>
> One question though: at the beginning of the chapter, you say "A media query is a method of testing certain aspects of the [Scene](https://github.com/openjdk/jfx/javafx/scene/Scene.html)" but this is not strictly true, since the Stage is also involved.
>
> Do you think we should mention "and/or Stage" or something like that?
>
> Moreover, what if other media queries are added that depend on some other aspects? Maybe we should specify whose properties we are looking at in the comments, like "width" -> "Scene width" ? What do you think?
Good idea, I've added that to the description.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1844#discussion_r2624789401
More information about the openjfx-dev
mailing list