RFR: 8358450: Viewport characteristics media features [v13]
Andy Goryachev
angorya at openjdk.org
Tue Dec 16 21:35:50 UTC 2025
On Tue, 16 Dec 2025 21:27:35 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/css/media/expression/RangeExpression.java line 118:
>>
>>> 116:
>>> 117: public interface Supplier {
>>> 118: RangeExpression getSizeExpression(SizeQueryType featureType, Size sizeValue);
>>
>> minor: could we use a name other than Supplier to avoid clashing with java.util.function one (it is confusing).
>
> I've thought about that, but then I never use that type unqualified (i.e. always as `RangeExpression.Supplier`), and because it's so localized, I don't want to make it a top-level interface. A more verbose name like `RangeExpression.ExpressionSupplier` looks very chatty...
ESupplier? RProvider? but if the access is always qualified, we are good.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1844#discussion_r2624813589
More information about the openjfx-dev
mailing list