RFR: 8373908: XYChart (ScatteredChart) leaks memory when removing data [v2]
John Hendrikx
jhendrikx at openjdk.org
Fri Dec 19 08:57:00 UTC 2025
On Fri, 19 Dec 2025 00:19:54 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
> I think a second reviewer couldn't hurt. I only have two questions:
>
> 1. I presume that moving the local listeners to be instance variables is needed? At first glance, I couldn't figure out why.
> 2. Is a test feasible? If not, we should consider filing a follow-up.
1. It is not needed, but they also don't need to be recreated each time as they're constant
2. I think a test may be possible, we can check if the data objects get GC'd
I'm neutral on the get property thing
-------------
PR Comment: https://git.openjdk.org/jfx/pull/2013#issuecomment-3674163720
More information about the openjfx-dev
mailing list