RFR: 8366739: ToolBar: overflow menu with fractional scale (2)
khanbilal732
duke at openjdk.org
Sun Dec 21 21:02:14 UTC 2025
On Sun, 21 Dec 2025 02:42:12 GMT, Cormac Redmond <duke at openjdk.org> wrote:
> Fix overflow menu triggering due to floating-point precision error.
>
> At 1.25 display scaling on Windows, floating-point comparison errors (e.g. 109.60000000000001 > 109.6) cause the overflow menu to appear when the lefthand value is regarded as larger than the righthand value.
>
> These should be treated as equal (and therefore not display the overflow menu).
>
> This bug can happen in both horizontal and vertical toolbar orientation.
>
> The new tests added fail without this fix, and pass with it. An existing test has been re-factored slightly to allow re-use and more flexibility in specifying the scene's root node.
Marked as reviewed by khanbilal732 at github.com (no known OpenJDK username).
Marked as reviewed by khanbilal732 at github.com (no known OpenJDK username).
-------------
PR Review: https://git.openjdk.org/jfx/pull/2016#pullrequestreview-3601921559
PR Review: https://git.openjdk.org/jfx/pull/2016#pullrequestreview-3601924760
More information about the openjfx-dev
mailing list