RFR: 8366739: ToolBar: overflow menu with fractional scale (2)
Andy Goryachev
angorya at openjdk.org
Mon Dec 22 17:00:11 UTC 2025
On Sun, 21 Dec 2025 02:42:12 GMT, Cormac Redmond <duke at openjdk.org> wrote:
> Fix overflow menu triggering due to floating-point precision error.
>
> At 1.25 display scaling on Windows, floating-point comparison errors (e.g. 109.60000000000001 > 109.6) cause the overflow menu to appear when the lefthand value is regarded as larger than the righthand value.
>
> These should be treated as equal (and therefore not display the overflow menu).
>
> This bug can happen in both horizontal and vertical toolbar orientation.
>
> The new tests added fail without this fix, and pass with it. An existing test has been re-factored slightly to allow re-use and more flexibility in specifying the scene's root node.
@credmond would you like to create a login in JBS and own the ticket https://bugs.openjdk.org/browse/JDK-8366739 so your fix gets properly credited?
-------------
PR Comment: https://git.openjdk.org/jfx/pull/2016#issuecomment-3682921630
More information about the openjfx-dev
mailing list