RFR: 8373038: Interpolator factories should follow method naming convention [v3]
Andy Goryachev
angorya at openjdk.org
Tue Dec 23 18:22:43 UTC 2025
On Tue, 23 Dec 2025 18:20:01 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:
>> The following interpolator factories don't follow the standard method naming convention:
>>
>> * `Interpolator.SPLINE(double, double, double, double)`
>> * `Interpolator.TANGENT(Duration, double, Duration, double)`
>> * `Interpolator.TANGENT(Duration, double)`
>> * `Interpolator.STEPS(int, StepPosition)`
>>
>> New methods named `ofSpline`, `ofTangent`, and `ofSteps` are added. The existing methods are deprecated (not for removal) in favor of the correctly-named methods. This change is in line with the new `ofLinear` method added with #1977.
>
> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>
> replace reference to STEPS
Marked as reviewed by angorya (Reviewer).
modules/javafx.graphics/src/main/java/javafx/animation/Interpolator.java line 220:
> 218: /**
> 219: * This is a legacy method named inconsistently with method naming conventions,
> 220: * use {@link #ofSpline(double, double, double, double)} instead.
+1, thanks!
-------------
PR Review: https://git.openjdk.org/jfx/pull/1996#pullrequestreview-3608919539
PR Review Comment: https://git.openjdk.org/jfx/pull/1996#discussion_r2643948938
More information about the openjfx-dev
mailing list