RFR: 8373058: Media crash when playing MP3 over JRT protocol on macOS 26
Alexander Matveev
almatvee at openjdk.org
Tue Dec 23 22:29:19 UTC 2025
On Tue, 23 Dec 2025 22:14:32 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Fixed two crashes:
>> - `shouldWaitForLoadingOfRequestedResource()` was not synchronized with `dispose()`.
>> - `AddBand()`, `RemoveBand()` and `MoveBand()` was not synchronized with `ProcessBufferLists()`.
>
> modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioEqualizer.h line 155:
>
>> 153:
>> 154: void lockBands() {
>> 155: pthread_mutex_lock(&mBandLock);
>
> I assume `int pthread_mutex_[lock|unlock]()` returns some kind of error code. should we check it?
Maybe. Other code we have does not check it.
https://github.com/openjdk/jfx/blob/master/modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioSpectrumUnit.h#L112
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2008#discussion_r2644375446
More information about the openjfx-dev
mailing list