RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v2]
John Hendrikx
jhendrikx at openjdk.org
Sat Feb 1 12:22:54 UTC 2025
On Tue, 17 Oct 2023 05:16:23 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:
>> Thanks, I'll look into that, it might speed up the 1 listener cases a bit. The same applies to OldValueCachingListenerManager#getValue I think. I know it isn't possible for the add/remove calls, as the data may change if they're nested, but for `fireValueChanged` I never really checked after going to this strategy.
>
> Have you considered passing `data` directly into the method? What is your conclusion?
It almost has to work, considering the `getData` call is done immediately after the `fireValueChanged` call :) I'll make the changes and run some tests.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1081#discussion_r1938266146
More information about the openjfx-dev
mailing list