RFR: 8349008: Remove temporary font file tracking code
Lukasz Kostyra
lkostyra at openjdk.org
Mon Feb 3 10:13:57 UTC 2025
On Fri, 31 Jan 2025 15:50:08 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> This is a cleanup follow-up, removing `FontFileWriter.FontTracker` and all related uses. `FontTracker` was tracking font size use when SecurityManager was present, however since we removed SM, `FontTracker` was no longer activated and as such was dead code.
>>
>> `FontFileWriter.FontTracker` and its use in `FontFileWriter` + related methods were removed. This in turn cleaned up `PrismFontFile` and made a couple of variables not longer used, including a `bool tracking` argument in constructor. These cleanups propagated to `PrismFontFactory`, `{CT,DW,FT}Factory` and `{CT,DW,FT}FontFile` classes.
>>
>> Tests worked the same after this change.
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/font/PrismFontFactory.java line 212:
>
>> 210: int fIndex, boolean register,
>> 211: boolean embedded,
>> 212: boolean copy)
>
> might want to change the copyright year to 2025
Oh I did miss that file didn't I... I think it's time to make a pre-commit hook or something to take care of that for me
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1693#discussion_r1939119217
More information about the openjfx-dev
mailing list