RFR: 8342565: [TestBug] StubTextLayout [v2]

[Marius Hanl]

On Wed, 29 Jan 2025 19:01:40 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Changed the StubTextLayout to use product PrismTextLayout with much simplified glyph layout (via stubbed fonts).  The new layout assumes all the glyphs are squares of font size, while the bold type face produces wider glyphs (by 1 pixel).  The default font size has changed from 10 to 12 to make it closer to win/linux.
>> 
>> This brings the test environment closer to the product configuration and expands the capabilities of our headless testing pipeline, which will be useful for upcoming behavior tests.
>> 
>> Existing tests have been adjusted/reworked mainly due to default font size change.
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 19 additional commits since the last revision:
> 
>  - atomic boolean
>  - Merge branch 'master' into 8342565.stub.text.layout
>  - cleanup
>  - better test
>  - cleanup
>  - more magic
>  - magic numbers
>  - more
>  - add exports
>  - stub fonts
>  - ... and 9 more: https://git.openjdk.org/jfx/compare/e1000640...5010278f

modules/javafx.controls/src/test/java/test/javafx/scene/control/ListViewTest.java line 2704:

> 2702:     private static double toViewPortLength(double prefHeight) {
> 2703:         // it would be better to calculate this from listView but there is no API for this
> 2704:         return prefHeight - 2;

I think after this node is inside the scene tree and has a skin, you can just calculate that with: 
`prefHeight(-1) - snappedTopInset() - snappedBottomInset()`. 
Something like that I already used.

Also, `Viewport` is one word, so should not be camel case.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1667#discussion_r1940746119