RFR: 8313424: JavaFX controls in the title bar [v47]
Kevin Rushforth
kcr at openjdk.org
Tue Feb 4 13:19:24 UTC 2025
On Tue, 4 Feb 2025 12:41:24 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:
>> Implementation of [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09) and `EXTENDED_UTILITY` stage style.
>
> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>
> add "maximized" pseudo-class for custom maximize button
It looks like this is shaping up nicely. I'll put this on my review queue.
One thing I wanted to raise is that there are a few new concepts here as well as a reasonably large API surface. This feature seems like a good candidate to release as a Preview Feature (*) to get more feedback on the API before finalizing it. That would mean reviving your [Preview Feature JEP / Draft PR](https://github.com/openjdk/jfx/pull/1359), which you had also mentioned as something to consider in your initial Description of this PR. Do you have any thoughts on this?
(*) - It can't be an incubator module (at least not without doing something unnatural like creating a subclass of Stage, and that might not even work), since the new API elements and implementation are necessarily in the `javafx.graphics module`.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1605#issuecomment-2633879403
More information about the openjfx-dev
mailing list