RFR: 8335587: TextInputControl: Binding prompt text that contains linebreak causes exception [v2]
Michael Strauß
mstrauss at openjdk.org
Tue Feb 4 16:18:16 UTC 2025
On Tue, 4 Feb 2025 16:01:03 GMT, Ziad El Midaoui <duke at openjdk.org> wrote:
>> When binding the promptTextProperty of a TextInputControl (TextField or TextArea) to a text that contains linebreaks/newlines ("\n") the "bind" call causes a RuntimeException to be thrown, the solution to it is to unbind before calling the set(txt) method to set the new value for the property.
>> Also added tests to test this new fix
>
> Ziad El Midaoui has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix formatting in TextInputControl.java
I guess I don't see the point of this particular ticket. This PR doesn't contain any useful change, because it is entirely subsumed in JDK-8335547. Why add code here and bother reviewers (even slightly), when the actual fix is to just remove the code? Even as an interim fix, it's mostly a waste of time for an issue that has existed for 13 years.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1694#issuecomment-2634447439
More information about the openjfx-dev
mailing list