RFR: 8335587: TextInputControl: Binding prompt text that contains linebreak causes exception [v2]

[Andy Goryachev]

On Tue, 4 Feb 2025 16:01:03 GMT, Ziad El Midaoui <duke at openjdk.org> wrote:

>> When binding the promptTextProperty of a TextInputControl (TextField or TextArea) to a text that contains linebreaks/newlines ("\n") the "bind" call causes a RuntimeException to be thrown, the solution to it is to unbind before calling the set(txt) method to set the new value for the property.
>> Also added tests to test this new fix
>
> Ziad El Midaoui has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix formatting in TextInputControl.java

Looks good in the MonkeyTester.

Thank you for providing unit tests and especially covering a complete set of scenarios (from the applied logic standpoint): null, with, and without newlines.

The fix is localized and well defined, so one reviewer is probably enough, but let's wait the prescribed time period (24h) to give other people a chance to take a look, especially @mstr2 :-)

-------------

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1694#pullrequestreview-2593641273