RFR: 8349373: Support JavaFX preview features

[Andy Goryachev]

On Wed, 7 Feb 2024 20:05:01 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

> This PR contains a definition of preview features for JavaFX, as well as a helper class to verify that an application has opted into preview features.

PREVIEW-FEATURES.md line 1:

> 1: # Preview features

is this a good location of this document?
should it be in /doc-files somewhere?

PREVIEW-FEATURES.md line 32:

> 30:    application has not opted into the use of preview features. All preview features have equal status
> 31:    in any given JavaFX release and can not be enabled individually.
> 32: 

do you want to talk about similarities and differences between this and jdk preview features https://openjdk.org/jeps/12 ?

PREVIEW-FEATURES.md line 45:

> 43:    for the preview feature. This name will be used in warning and error messages when the preview feature
> 44:    is used by application developers.
> 45: 4. Add runtime checks in appropriate places by invoking `com.sun.javafx.PreviewFeature.<FEATURE>.checkEnabled()`.

what do you think about adding this checklist to the PreviewFeature class?
possibly following by an example (to allow for copy-paste)?

modules/javafx.base/src/main/java/com/sun/javafx/PreviewFeature.java line 37:

> 35:  * has opted into preview features.
> 36:  */
> 37: public enum PreviewFeature {

Why enum?
Maybe use a regular class with a public constructor should do it.
What do you think?

modules/javafx.base/src/main/java/com/sun/javafx/PreviewFeature.java line 78:

> 76:     }
> 77: 
> 78:     private final String featureName;

would it be possible to move field to the beginning of the class please?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1359#discussion_r1941678440
PR Review Comment: https://git.openjdk.org/jfx/pull/1359#discussion_r1941685598
PR Review Comment: https://git.openjdk.org/jfx/pull/1359#discussion_r1941683672
PR Review Comment: https://git.openjdk.org/jfx/pull/1359#discussion_r1941689779
PR Review Comment: https://git.openjdk.org/jfx/pull/1359#discussion_r1941690914