RFR: 8348423: [TestBug] stress test Nodes initialization from a background thread [v8]

Andy Goryachev angorya at openjdk.org
Wed Feb 5 21:36:17 UTC 2025


On Tue, 4 Feb 2025 22:49:42 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   more jitter
>
> tests/system/src/test/java/test/robot/javafx/scene/NodeInitializationStressTest.java line 158:
> 
>> 156:     // for debugging purposes: setting this to true will skip working tests
>> 157:     // TODO remove once all the tests pass
>> 158:     private static final boolean SKIP_TEST = false;
> 
> I presume this is just for your convenience while developing this test as a way to run only the test you are interested in?

correct.

> tests/system/src/test/java/test/robot/javafx/scene/NodeInitializationStressTest.java line 782:
> 
>> 780:             new Thread(() -> {
>> 781:                 try {
>> 782:                     while (running.get()) {
> 
> Maybe exit early if there is a failure, e.g., `while (running.get() && !failed.get())`?
> 
> In order to be effective, the `UncaughtExceptionHandler` would need to interrupt the main thread (so that `sleep(DURATION)` terminates early), so we would need to register the main thread with the `UncaughtExceptionHandler`.
> 
> This could be a follow-on if we decide it is helpful (I'm not sure it's worth doing).

Probably not worth doing it - the test is relatively quick (even after we add all other  Nodes).

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1690#discussion_r1943688929
PR Review Comment: https://git.openjdk.org/jfx/pull/1690#discussion_r1943690492


More information about the openjfx-dev mailing list