RFR: 8348100: Tooltips cannot be instantiated on background thread [v3]
Michael Strauß
mstrauss at openjdk.org
Sun Feb 9 18:32:17 UTC 2025
On Fri, 7 Feb 2025 19:19:53 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> ## Root Cause
>> navigating up the parent hierarchy during CSS processing in a background thread encounters a null parent, causing the NPE. The null parent comes from a static Toolkit.BEHAVIOR field.
>>
>> ## Solution
>> avoid that code path if not in the fx application thread.
>
> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>
> behavior
Marked as reviewed by mstrauss (Reviewer).
modules/javafx.controls/src/main/java/javafx/scene/control/Tooltip.java line 74:
> 72: import com.sun.javafx.css.StyleManager;
> 73: import com.sun.javafx.scene.NodeHelper;
> 74: import com.sun.javafx.stage.PopupWindowHelper;
That's a lot of import noise for such a small patch...
-------------
PR Review: https://git.openjdk.org/jfx/pull/1696#pullrequestreview-2604330579
PR Review Comment: https://git.openjdk.org/jfx/pull/1696#discussion_r1948165334
More information about the openjfx-dev
mailing list