RFR: 8349091: Charts: exception initializing in a background thread [v2]

Andy Goryachev angorya at openjdk.org
Mon Feb 10 18:43:18 UTC 2025


On Mon, 10 Feb 2025 18:38:00 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 19 commits:
>> 
>>  - Merge branch 'master' into 8349091.charts.thread.safety
>>  - whitespace
>>  - Merge remote-tracking branch 'origin/master' into 8349091.charts.thread.safety
>>  - cleanup
>>  - tests pass
>>  - chart tests only
>>  - more jitter
>>  - Merge remote-tracking branch 'origin/master' into 8348423.node.thread.safety
>>  - skip tests
>>  - jiggler
>>  - ... and 9 more: https://git.openjdk.org/jfx/compare/2cf9779b...4b6089e4
>
> tests/system/src/test/java/test/robot/javafx/scene/NodeInitializationStressTest.java line 186:
> 
>> 184:             accessChart(c);
>> 185:             c.getData().setAll(createNumberSeries());
>> 186:             c.getData().setAll(createNumberSeries());
> 
> Just curious - why do we do setAll twice in all the tests?

good question!  this code exercises both remove and add code paths.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1697#discussion_r1949688772


More information about the openjfx-dev mailing list