RFR: 8348095: [Linux] Menu shows up in wrong position when using i3 windows manager in full screen mode [v3]
Thiago Milczarek Sayao
tsayao at openjdk.org
Tue Feb 11 11:51:26 UTC 2025
On Tue, 11 Feb 2025 10:57:04 GMT, Jose Pereda <jpereda at openjdk.org> wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Clarify the meaning of x and y.
>
> modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp line 983:
>
>> 981: geometry.y = root_y;
>> 982: geometry.view_x = origin_x - root_x;
>> 983: geometry.view_y = origin_y - root_y;
>
> Looks good, but maybe you could add a small comment about what `x/y` and `view_x/view_y` mean?
Done.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1702#discussion_r1950700602
More information about the openjfx-dev
mailing list