Integrated: 8349756: Memory leak in PaginationSkin when setting page count / index
Andy Goryachev
angorya at openjdk.org
Thu Feb 13 15:24:19 UTC 2025
On Tue, 11 Feb 2025 15:46:17 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
> ## Root Cause
>
> Each time a `PaginationSkin.IndicatorButton` gets created it adds two listeners (to the control's `styleClass` property and to the skin's tooltipVisible property) via `ListenerHelper`. This was not detected by the `SkinMemoryLeakTest` because all listeners got removed correctly upon skin change.
>
> ## Solution
>
> Add a single listener to the control's `styleClass` property at the skin level, and insert the call to the skin's `tooltipVisible` property both of which iterate over indicator button to do their thing.
This pull request has now been integrated.
Changeset: 167e1ee5
Author: Andy Goryachev <angorya at openjdk.org>
URL: https://git.openjdk.org/jfx/commit/167e1ee5513a7d769b24f2c74aebdd57c0d93722
Stats: 45 lines in 1 file changed: 27 ins; 13 del; 5 mod
8349756: Memory leak in PaginationSkin when setting page count / index
Reviewed-by: kcr, arapte
-------------
PR: https://git.openjdk.org/jfx/pull/1705
More information about the openjfx-dev
mailing list