RFR: 8349255: TitledPane: exception initializing in a background thread

Kevin Rushforth kcr at openjdk.org
Thu Feb 13 18:38:16 UTC 2025


On Wed, 12 Feb 2025 19:10:30 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> ## Root Cause
>> 
>> Animation was started in the background thread, causing concurrent access.
>> 
>> ## Solution
>> 
>> Disable animation if not the fx app thread.
>
> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 1442:
> 
>> 1440:                             // of this node, since visibility affects bounds of the
>> 1441:                             // parent node
>> 1442:                             p.childVisibilityChanged(Node.this);
> 
> it was a part of an earlier attempt, but I think this code is better.

I'd still revert it, since it is unrelated to the fix under review and is in a file that is otherwise untouched.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1707#discussion_r1955033058


More information about the openjfx-dev mailing list