RFR: 8348095: [Linux] Menu shows up in wrong position when using i3 windows manager in full screen mode [v4]
Thiago Milczarek Sayao
tsayao at openjdk.org
Fri Feb 14 13:31:04 UTC 2025
> The issue was with the view's position, specifically the content's X and Y coordinates relative to the window, including its decorations. When in fullscreen mode, the window remains decorated, but the decorations are hidden. As a result, the content's position needs to be recalculated to account for the window's adjusted layout.
>
> It's not specific to i3.
>
> I used `gdk_window_get_root_origin` because GTK provides a more robust mechanism to determine the value, even in cases where _NET_FRAME_EXTENTS is not supported by the window manager.
Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
- Merge branch 'master' into 8348095
- Clarify the meaning of x and y.
- Clarify the meaning of view_x and view_y.
- Forgot debug print
- 8348095: [Linux] Menu shows up in wrong position when using i3 windows manager in full screen mode
-------------
Changes:
- all: https://git.openjdk.org/jfx/pull/1702/files
- new: https://git.openjdk.org/jfx/pull/1702/files/bd12ebca..c2b56ab6
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jfx&pr=1702&range=03
- incr: https://webrevs.openjdk.org/?repo=jfx&pr=1702&range=02-03
Stats: 776269 lines in 8272 files changed: 646268 ins; 72273 del; 57728 mod
Patch: https://git.openjdk.org/jfx/pull/1702.diff
Fetch: git fetch https://git.openjdk.org/jfx.git pull/1702/head:pull/1702
PR: https://git.openjdk.org/jfx/pull/1702
More information about the openjfx-dev
mailing list