RFR: 8349098: TabPane: exception initializing in a background thread [v2]

Andy Goryachev angorya at openjdk.org
Fri Feb 14 17:49:16 UTC 2025


On Fri, 14 Feb 2025 16:23:58 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Although, having said that, the purpose of the cleanup is to clean up after the animation. So a better fix might be to put the entire if-else inside an `if (Platform.isFxApplicationThread())` test.
>
> Actually, no. It also calls requestLayout. I think the fix is correct as is.

Right.  The change prevents from _starting_ the animation if these code paths are entered in a background thread.  With the change, the code follows an animation-off path.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1699#discussion_r1956518465


More information about the openjfx-dev mailing list